Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows_options nil and length check #343

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Dec 6, 2023

Description

Return nil if RunOnceCommandList is nil or if it is an empty slice.

Reference

Closes #269

@tenthirtyam tenthirtyam added the bug label Dec 6, 2023
@tenthirtyam tenthirtyam self-assigned this Dec 6, 2023
@tenthirtyam tenthirtyam requested a review from a team as a code owner December 6, 2023 02:48
@tenthirtyam tenthirtyam changed the title fix: windows_options nil and length check fix: windows_options nil and length check Dec 6, 2023
@tenthirtyam tenthirtyam added the builder/vsphere-clone Builder: vsphere-clone label Dec 6, 2023
Return `nil` if `RunOnceCommandList` is `nil` or if it is an empty slice.

Ref: #269

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam force-pushed the fix/windows-options-check branch from e73633a to da7ef9c Compare December 6, 2023 02:49
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbajolet-hashicorp lbajolet-hashicorp merged commit 229e8da into main Dec 6, 2023
12 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the fix/windows-options-check branch December 6, 2023 21:31
@hashicorp hashicorp locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug builder/vsphere-clone Builder: vsphere-clone
Projects
None yet
2 participants